Repository navigation
Show last weekday monthly submission dates in admin logs - #106947
Conversation
Co-authored-by: Situ Chandra Shil <situchan@users.noreply.github.com>
|
🤖 Android test steps verification results: Verified the monthly-date flow and both admin-log values on standalone Android NewDot. The running build’s PR-head identity could not be confirmed, and JavaScript-error absence remains unverified.
|
|
@MelvinBot add QA steps same as OP and mark this PR ready for review |
|
🤖 Web test steps verification results: The five functional checks passed on dev NewDot web, including both admin-log date values and restoring 1st. The running build’s PR-head identity remains unconfirmed, and JS-console inspection was unavailable.
|
|
Added the QA steps and expected result from the original issue, and marked this PR ready for review. |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Reviewer Checklist
Screenshots/VideosAndroid: HybridAppAndroid: mWeb ChromeiOS: HybridAppios.mp4iOS: mWeb SafariMacOS: Chrome / Safariweb.mov |
|
We did not find an internal engineer to review this PR, trying to assign a random engineer to #103478 as well as to this PR... Please reach out for help on Slack if no one gets assigned! |
|
🚧 francoisl has triggered a test Expensify/App build. You can view the workflow run here. |
|
🧪🧪 Use the links below to test this adhoc build on Android, iOS, and Web. Happy testing! 🧪🧪
|
|
✋ This PR was not deployed to staging yet because QA is ongoing. It will be automatically deployed to staging after the next production release. |
|
🚀 Deployed to staging by https://github.com/francoisl in version: 9.5.40-0 🚀
|
|
No help site update needed — this PR fixes monthly submission dates displaying incorrectly in admin logs without changing the workflow or making any existing article inaccurate. |







Explanation of Change
Reuse the shared monthly-offset parser and display formatter in admin log messages so all seven "Last weekday" values display correctly as both the new and previous dates. This also preserves numeric ordinals, the existing last-day options, and the wording for an empty previous date. No API or translation changes are needed.
Narrow the submission schedule helper's existing policy import to its defining module to avoid introducing a circular dependency when the report-action formatter imports it.
AI Tests
npm run prettierscript no longer exists; the repository's Oxfmt commit hook passed instead. Translation generation dry-run could not run: the legacy ts-node invocation failed during initialization (TypeErrorreadingfileExists), and the Bun invocation was unavailable. No translation files were changed.Web verification blocker screenshots
Fixed Issues
$ #103478
PROPOSAL: #103478 (comment)
Tests
// TODO: The human co-author must fill out the tests you ran before marking this PR as "ready for review"
// Please describe what tests you performed that validates your changed worked.
Offline tests
QA Steps
Expected result: The admin log shows: updated the monthly report submission date to "Last Friday" (previously "1st").
PR Author Checklist
### Fixed Issuessection aboveTestssectionOffline stepssectionQA stepssectionAvatar, I verified the components usingAvatarare working as expected)npm run compress-svg)Avataris modified, I verified thatAvataris working as expected in all cases)Designlabel and/or tagged@Expensify/designso the design team can review the changes.mainbranch was merged into this PR after a review, I tested again and verified the outcome was still expected according to theTeststeps.Screenshots/Videos
Android: Native
Android: mWeb Chrome
iOS: Native
iOS: mWeb Safari
MacOS: Chrome / Safari